From: Ben Hutchings <bhutchings@xxxxxxxxxxxxxx> Date: Mon, 3 Sep 2012 13:44:27 +0100 > On Mon, 2012-09-03 at 09:47 +0200, Giuseppe CAVALLARO wrote: >> This patch adds the sysFs support. >> Some internal driver parameters can be tuned by using some >> entries exposed via sysFS. There parameter currently are, >> for example, for internal timers used to mitigate the rx/tx >> interrupts or for EEE. > [...] > > Why are you not exposing these through the standard ethtool operations? Guiseppe, I'm not appyling driver patches that add sysfs crap like this. Either use existing ethtool interfaces or create new ones that provide the necessary functionality. Adding unique configuration mechanisms to a device driver is always a bug. And I'm getting real fed up with driver writers simply not getting the message. Every time someone adds sysfs or ioctl crap, we push back, so just don't do it and stop wasting our time. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html