On Fri, Mar 13, 2020 at 05:23:18PM +0200, Nikolay Borisov wrote:
> --- a/include/uapi/linux/btrfs.h
> +++ b/include/uapi/linux/btrfs.h
> @@ -36,7 +36,6 @@ struct btrfs_ioctl_vol_args {
> #define BTRFS_DEVICE_PATH_NAME_MAX 1024
> #define BTRFS_SUBVOL_NAME_MAX 4039
>
> -#define BTRFS_SUBVOL_CREATE_ASYNC (1ULL << 0)
Removing it completely is probably fine but the 1st bit must not be
reused anytime soon, so at least some comment should be left here.
> #define BTRFS_SUBVOL_RDONLY (1ULL << 1)
> #define BTRFS_SUBVOL_QGROUP_INHERIT (1ULL << 2)
>
> @@ -45,8 +44,7 @@ struct btrfs_ioctl_vol_args {
> #define BTRFS_SUBVOL_SPEC_BY_ID (1ULL << 4)
>
> #define BTRFS_VOL_ARG_V2_FLAGS_SUPPORTED \
> - (BTRFS_SUBVOL_CREATE_ASYNC | \
> - BTRFS_SUBVOL_RDONLY | \
> + (BTRFS_SUBVOL_RDONLY | \
> BTRFS_SUBVOL_QGROUP_INHERIT | \
> BTRFS_DEVICE_SPEC_BY_ID | \
> BTRFS_SUBVOL_SPEC_BY_ID)
> @@ -116,8 +114,7 @@ struct btrfs_ioctl_qgroup_limit_args {
>
> /* Supported flags for BTRFS_IOC_SNAP_CREATE_V2 and BTRFS_IOC_SUBVOL_CREATE_V2 */
> #define BTRFS_SUBVOL_CREATE_ARGS_MASK \
> - (BTRFS_SUBVOL_CREATE_ASYNC | \
> - BTRFS_SUBVOL_RDONLY | \
> + (BTRFS_SUBVOL_RDONLY | \
So this would catch any potential use of the flag and the ioctl can
simply remove all the related code. Ok.
