On Mon, Mar 09, 2020 at 02:32:28PM -0700, Omar Sandoval wrote: > +static void btrfs_submit_direct_hook(struct btrfs_dio_private *dip) Just curious: why is this routine called btrfs_submit_direct_hook? it doesn't seem to hook up anything, but just contains the guts of btrfs_submit_direct. Any reason to keep the two functions separate? Also instead of the separate bip allocation and the bio clone, why not clone into a private bio_set that contains the private data as part of the allocation?
