From: Omar Sandoval <osandov@xxxxxx>
The purpose of the validation step is to distinguish between good and
bad sectors in a failed multi-sector read. If a multi-sector read
succeeded but some of those sectors had checksum errors, we don't need
to validate anything; we know the sectors with bad checksums need to be
repaired.
Signed-off-by: Omar Sandoval <osandov@xxxxxx>
---
fs/btrfs/extent_io.c | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index 279731bff0a8..104374854cf1 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -2640,8 +2640,6 @@ static int bio_readpage_error(struct bio *failed_bio, u64 phy_offset,
struct extent_io_tree *tree = &BTRFS_I(inode)->io_tree;
struct extent_io_tree *failure_tree = &BTRFS_I(inode)->io_failure_tree;
bool need_validation = false;
- u64 len;
- int i;
struct bio *bio;
int read_mode = 0;
blk_status_t status;
@@ -2654,15 +2652,19 @@ static int bio_readpage_error(struct bio *failed_bio, u64 phy_offset,
return ret;
/*
- * We need to validate each sector individually if the I/O was for
- * multiple sectors.
+ * If there was an I/O error and the I/O was for multiple sectors, we
+ * need to validate each sector individually.
*/
- len = 0;
- for (i = 0; i < failed_bio->bi_vcnt; i++) {
- len += failed_bio->bi_io_vec[i].bv_len;
- if (len > inode->i_sb->s_blocksize) {
- need_validation = true;
- break;
+ if (failed_bio->bi_status != BLK_STS_OK) {
+ u64 len = 0;
+ int i;
+
+ for (i = 0; i < failed_bio->bi_vcnt; i++) {
+ len += failed_bio->bi_io_vec[i].bv_len;
+ if (len > inode->i_sb->s_blocksize) {
+ need_validation = true;
+ break;
+ }
}
}
--
2.25.1
