On 2020/3/4 上午12:30, David Sterba wrote: > On Tue, Mar 03, 2020 at 03:13:50PM +0800, Qu Wenruo wrote: >> The patchset is based on previous backref_cache_refactor branch, which >> is further based on misc-next. >> >> The whole series can be fetched from github: >> https://github.com/adam900710/linux/tree/backref_cache_code_move >> >> All the patches in previous branch is not touched at all, thus they are >> not re-sent in this patchset. > > The patches are cleanups and code moving, please fix the coding style > issues you find. > > * missing lines between declarations and statements > * exported functions need btrfs_ prefix I have some question about this. Sometimes the "btrfs_" prefix requirement looks too mechanical. Some functions, like backref_cache_init() is very obvious related to backref cache. I can't see any special benefit from adding a "btrfs_" prefix. Thanks, Qu > * comments should start with an upper case letter unless it's an > identifier, formatted to 80 columns > > As this patchset depends on another one I'm not sure if it's right time > to update it now, before the other one is merged as I think the same > code is touched and this would cause extra work. > > Overall it makes sensed to add more to backref.[hc] and export that as > an internal API. >
Attachment:
signature.asc
Description: OpenPGP digital signature
