Re: [PATCH] btrfs-progs: convert, warn if converting a fs which won't mount

Anand Jain <anand.jain@xxxxxxxxxx> · Wed, 4 Mar 2020 23:22:51 +0800

On 3/4/20 9:32 PM, David Sterba wrote:
On Wed, Mar 04, 2020 at 10:14:20AM +0800, Anand Jain wrote:
the conversion.

I've tried mkfs.ext4 with 64k block size and it warns and in the
interactive session wants to confirm that by the user:

    $ mkfs.ext4 -b 64k img
    Warning: blocksize 65536 not usable on most systems.
    mke2fs 1.45.5 (07-Jan-2020)
    img contains a ext4 file system
	  created on Tue Mar  3 18:41:46 2020
    Proceed anyway? (y,N) y
    mkfs.ext4: 65536-byte blocks too big for system (max 4096)
    Proceed anyway? (y,N) y
    Warning: 65536-byte blocks too big for system (max 4096), forced to continue
    Creating filesystem with 32768 64k blocks and 32768 inodes

    Allocating group tables: done
    Writing inode tables: done
    Creating journal (4096 blocks): done
    Writing superblocks and filesystem accounting information: done

Just warn is reasonable. But I don't think you meant to introduce
interactive part similar to mkfs.ext4 in btrfs-convert?

No I haven't meant that. So let's go with the warning.

Ok. Patch v2 is in ML.

Thanks, Anand