Re: [PATCH 3/3] btrfs: relocation: Remove the open-coded goto loop for breadth-first search

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2020/2/28 上午8:08, Qu Wenruo wrote:
> 
> 
> On 2020/2/28 上午3:51, Josef Bacik wrote:
>> On 2/24/20 1:02 AM, Qu Wenruo wrote:
>>> build_backref_tree() uses "goto again;" to implement a breadth-first
>>> search to build backref cache.
>>>
>>> This patch will extract most of its work into a wrapper,
>>> handle_one_tree_block(), and use a while() loop to implement the same
>>> thing.
>>>
>>> Signed-off-by: Qu Wenruo <wqu@xxxxxxxx>
>>
>> Do you have this in a tree somewhere that I can look at it?  I tried
>> applying these but they don't apply cleanly to anything I have, and it's
>> hard to review this one without seeing how the code ends up after your
>> diff.  Thanks,
> 
> Sure, here you go:
> https://github.com/adam900710/linux/tree/backref_cache_new
> 
> But please ignore the latest 1 or 2 commits, as they are still under
> development.
> 
> Every submitted patches will not undergo any extra modification in that
> branch.

Except this commit,  "btrfs: relocation: Rename mark_block_processed()
and __mark_block_processed()", Nikolay had some pretty good advice on
it, and it's updated to address his comment.

Thanks,
Qu
> 
> Thanks,
> Qu
> 
>>
>> Josef
> 

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux