Re: [PATCH v2 0/5] Fix memory leak on failed cache-writes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18/02/2020 17:50, David Sterba wrote:
> On Fri, Feb 14, 2020 at 12:57:58AM +0900, Johannes Thumshirn wrote:
>> Fstests' test case generic/475 reliably leaks the btrfs_io_ctl::pages
>> allocated in __btrfs_write_out_cache().
>>
>> The first patch in this series is freeing the pages when we throw away a dirty
>> block group. The other patches are small things I noticed while hunting down the
>> problem and are independant of fix.
>>
>> Changes to v1:
>> - Move fix to the first position (David)
>>
>> Johannes Thumshirn (5):
>>    btrfs: free allocated pages on failed cache write-out
>>    btrfs: use inode from io_ctl in io_ctl_prepare_pages
>>    btrfs: make the uptodate argument of io_ctl_add_pages() boolean.
>>    btrfs: use standard debug config option to enable free-space-cache
>>      debug prints
>>    btrfs: simplify error handling in __btrfs_write_out_cache()
> 
> I've seen some weird test failures and this patchset was in the tested
> branch (either for-next or standalone). I need to retest misc-next again
> to have a clean baseline so I can see the diff.
> 

Interesting, can you forward me the failures?





[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux