Re: [PATCH 0/5] Fix memory leak on failed cache-writes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/11/20 10:10 AM, Johannes Thumshirn wrote:
Fstests' test case generic/475 reliably leaks the btrfs_io_ctl::pages
allocated in __btrfs_write_out_cache().

The first four patches are small things I noticed while hunting down the
problem and are independant of the last patch in this series freeing the pages
when we throw away a dirty block group.

Johannes Thumshirn (5):
   btrfs: use inode from io_ctl in io_ctl_prepare_pages
   btrfs: make the uptodate argument of io_ctl_add_pages() boolean.
   btrfs: use standard debug config option to enable free-space-cache
     debug prints
   btrfs: simplify error handling in __btrfs_write_out_cache()
   btrfs: free allocated pages jon failed cache write-out

  fs/btrfs/disk-io.c          |  6 ++++++
  fs/btrfs/free-space-cache.c | 44 ++++++++++++++++++++++++--------------------
  fs/btrfs/free-space-cache.h |  1 +
  3 files changed, 31 insertions(+), 20 deletions(-)


Weird, I swear I reviewed these yesterday, but I don't see any replies from me. You can add

Reviewed-by: Josef Bacik <josef@xxxxxxxxxxxxxx>

to the whole series.  Thanks,

Josef



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux