On 12/02/2020 08:28, Christoph Hellwig wrote: >> - Warn if we can't write out a page for a superblock (David) > > Shouldn't there be some real error handling instead of just a warning? > At least shut down the file system? Looking at the callers of btrfs_scratch_superblock() I don't think so. btrfs_scratch_superblock() is called by btrfs_rm_device(), btrfs_rm_dev_replace_free_srcdev() and btrfs_destroy_dev_replace_tgtdev(). So it's all functions related to removing a device from a multi device file-system. Do you really want to shut down the file-system if clearing the magic in one of the super-blocks of a disk that is to be removed from the file-system doesn't work? I think it's better to warn the administrator that something didn't work all to well and to be cautious with that disk if he/she ever want's to put it back than shut down the whole FS. Thanks, Johannes
