On 2020/2/11 上午12:09, David Sterba wrote:
> On Mon, Feb 10, 2020 at 05:02:01PM +0800, Qu Wenruo wrote:
>> Since commit ecd4bb607f35 ("btrfs-progs: docs: enhance btrfs-filesystem
>> manual page"), the man page of `btrfs filesystem` shows `sync`
>> subcommand will wait for all existing orphan subvolumes to be dropped.
>
> But this is not what the docs say, nor what the ioctl claims to do.
>
> 'trigger cleaning of deleted subvolumes' means that it just starts the
> process in some way (eg. by waking up the cleaner kthread that does the
> actual cleaning).
Then at least we shouldn't really confuse the end user (me included)
about the cleanup.
In fact the cleaner wake up doesn't really have a user-observable impact.
We should at least avoid mentioning such thing.
Thanks,
Q
>
> For waiting on the subvolumes there's 'btrfs subvol sync' and that works
> as expected.
>
