On 2020-02-10 09:02, Qu Wenruo wrote:
Since commit ecd4bb607f35 ("btrfs-progs: docs: enhance btrfs-filesystem
manual page"), the man page of `btrfs filesystem` shows `sync`
subcommand will wait for all existing orphan subvolumes to be dropped.
That's not true, even at that commit, `btrfs fi sync` only calls
BTRFS_IOC_SYNC ioctl, which is not that much different from vanilla
sync.
It doesn't wait for orphan subvolumes to be dropped from the very
beginning.
It's `btrfs subvolume sync` doing the wait work.
Reported-by: Nikolay Borisov <nborisov@xxxxxxxx>
Fixes: ecd4bb607f35 ("btrfs-progs: docs: enhance btrfs-filesystem
manual page")
Signed-off-by: Qu Wenruo <wqu@xxxxxxxx>
---
Documentation/btrfs-filesystem.asciidoc | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/Documentation/btrfs-filesystem.asciidoc
b/Documentation/btrfs-filesystem.asciidoc
index 84efaa1a8f8f..3f62a3608cb1 100644
--- a/Documentation/btrfs-filesystem.asciidoc
+++ b/Documentation/btrfs-filesystem.asciidoc
@@ -253,9 +253,8 @@ show sizes in GiB, or GB with --si
show sizes in TiB, or TB with --si
*sync* <path>::
-Force a sync of the filesystem at 'path'. This is done via a special
ioctl and
-will also trigger cleaning of deleted subvolumes. Besides that it's
equivalent
-to the `sync`(1) command.
+Force a sync of the filesystem at 'path'. This should be the same as
vanilla
^^^^^^
As a user I don't like the use of "should" here. Can we not keep the
wording of "is equivalent to the `sync(1)` command [but only for the
specified btrfs filesystem]"?
--
Steven Davies
+'sync' command, but only for specified btrfs.
*usage* [options] <path> [<path>...]::
Show detailed information about internal filesystem usage. This is
supposed to
