On Fri, Jan 24, 2020 at 09:32:39AM -0500, Josef Bacik wrote: > We look up the reloc roots corresponding root, we need to hold a ref on > that root. > > Signed-off-by: Josef Bacik <josef@xxxxxxxxxxxxxx> > --- > fs/btrfs/relocation.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c > index 990595a27a15..53df57b59bc3 100644 > --- a/fs/btrfs/relocation.c > +++ b/fs/btrfs/relocation.c > @@ -2474,6 +2474,8 @@ int prepare_to_merge(struct reloc_control *rc, int err) > list_del_init(&reloc_root->root_list); > > root = read_fs_root(fs_info, reloc_root->root_key.offset); > + if (!btrfs_grab_fs_root(root)) > + BUG(); > BUG_ON(IS_ERR(root)); These two should be swapped, first the root is "checked" if it's valid, then the reference can be grabbed. The code is later pushed into the other helper and there it's in the right order so it's only temporary. > BUG_ON(root->reloc_root != reloc_root); >
