Re: [PATCH] btrfs: drop math for block_reserved which is block_rsv size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2/4/20 7:10 PM, Nikolay Borisov wrote:


On 4.02.20 г. 13:05 ч., Anand Jain wrote:
In btrfs_update_global_block_rsv the lines
   num_bytes = block_rsv->size - block_rsv->reserved;
   block_rsv->reserved += num_bytes;
imply
   block_rsv->reserved = block_rsv->size;

Just assign block_rsv->size to block_rsv->reserved instead of the math.

Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx>
---
  fs/btrfs/block-rsv.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/block-rsv.c b/fs/btrfs/block-rsv.c
index 6dacde9a7e93..62e0885c1e5d 100644
--- a/fs/btrfs/block-rsv.c
+++ b/fs/btrfs/block-rsv.c
@@ -304,9 +304,9 @@ void btrfs_update_global_block_rsv(struct btrfs_fs_info *fs_info)
if (block_rsv->reserved < block_rsv->size) {
  		num_bytes = block_rsv->size - block_rsv->reserved;
-		block_rsv->reserved += num_bytes;
  		btrfs_space_info_update_bytes_may_use(fs_info, sinfo,
  						      num_bytes);
+		block_rsv->reserved = block_rsv->size;

Any particular reason why you put the assignment after
btrfs_space_info_update_bytes_may_use and not before?

 Oh. To make it similar to the else if part below.

Thanks.

  	} else if (block_rsv->reserved > block_rsv->size) {
  		num_bytes = block_rsv->reserved - block_rsv->size;
  		btrfs_space_info_update_bytes_may_use(fs_info, sinfo,




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux