On 24/01/2020 15:22, David Sterba wrote: [...] >> >> - brelse(bh); >> + btrfs_release_disk_super(page); > > This could be the cleaned up to merge all error exits to jump to this > common block. Integrity checker is an old code so nobody cared enough to > clean it up, but it would be good to do it now when there are pople > looking at the code. > > As mentioned before, btrfs_release_disk_super should be opencoded so > this would make it more straightfowrard to have only one place instad of > each error exit brelse replaced by put_page/kunmap. Sure no problem. I already have a internal branch with put_page()/kunmap(), but before sending it out I want to address Nikolay's comments regarding the page locking and this still causes deadlocks here. Thanks, Johannes
