Re: [PATCH] btrfs-progs: fix btrfs-qgroup man page as unstable feature

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2020/1/24 下午4:46, Anand Jain wrote:
> 
> 
> On 24/1/20 3:28 PM, Qu Wenruo wrote:
>>
>>
>> On 2020/1/24 下午3:25, Anand Jain wrote:
>>> There are known performance and counting errors for the quota when
>>> qgroup is
>>> enabled.
>>
>> Counting error is a big problem, please report if you found one not
>> caused by impersistent qgroup status.
> 
>  I mean the already known issues btrfs/153 (count error on write to
>  falloc-ed space) 

This is not count error, it's reserved space/limit error.

>and btrfs/179 (after a lot of snapshot
>  create and distroy with fsstress on subvol the btrfs check
>  reports qgroup count diff).

I haven't yet reproduce it, it would be nice to have a separate report.

> 
>> For performance, we still have problem, but that should only be snapshot
>> dropping.
>> Balance is no longer a big problem.
>>
>> Personally I think the current man page still stands.
> 
>  IMO kernel version in the man page is bit confusing though when
>  its still unstable.

OK, for the kernel version part the patch makes sense.

Thanks,
Qu

> 
> Thanks, Anand
> 
>> Thanks,
>> Qu
>>>
>>> Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx>
>>> ---
>>>   Documentation/btrfs-qgroup.asciidoc | 3 +--
>>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/btrfs-qgroup.asciidoc
>>> b/Documentation/btrfs-qgroup.asciidoc
>>> index 0c9f5940a1d3..2da3d7819ba6 100644
>>> --- a/Documentation/btrfs-qgroup.asciidoc
>>> +++ b/Documentation/btrfs-qgroup.asciidoc
>>> @@ -16,8 +16,7 @@ DESCRIPTION
>>>   NOTE: To use qgroup you need to enable quota first using *btrfs
>>> quota enable*
>>>   command.
>>>   -WARNING: Qgroup is not stable yet and will impact performance in
>>> current mainline
>>> -kernel (v4.14).
>>> +WARNING: Qgroup is an unstable feature as of now.
>>>     QGROUP
>>>   ------
>>>
>>

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux