Re: [PATCH v2 2/6] btrfs: remove buffer heads from super block reading

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23/01/2020, 14:51, "Josef Bacik" <josef@xxxxxxxxxxxxxx> wrote:
[...]
    > -		brelse(bh);
    > +
    > +		bio.bi_iter.bi_sector = bytenr >> SECTOR_SHIFT;
    > +		bio_set_dev(&bio, bdev);
    > +		bio_set_op_attrs(&bio, REQ_OP_WRITE, 0);
    nit: We're losing REQ_SYNC here, not that it matters but if you have to re-roll 
    it may be nice to have.  Otherwise
    
No actually we don't. submnit_bio_wait() implies REQ_SYNC, so we're all good.

    Reviewed-by: Josef Bacik <josef@xxxxxxxxxxxxxx>

Thanks,
	Johannes
   





[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux