On Wed, Jan 15, 2020 at 09:03:13AM +0000, Graham Cobb wrote: > OK, I have bisected the problem with scrub resume being broken by the > scrub ioctl ABI being changed. Thanks for the bisecting, I'll forward the fix to 5.5-rc so it can be picked by stable trees. The regression has been there since 5.1, which at the moment is only for 5.4.x. > The bad commit is: > > 06fe39ab15a6a47d4979460fcc17d33b1d72ccf9 is the first bad commit > commit 06fe39ab15a6a47d4979460fcc17d33b1d72ccf9 > Author: Filipe Manana <fdmanana@xxxxxxxx> > Date: Fri Dec 14 19:50:17 2018 +0000 > > Btrfs: do not overwrite scrub error with fault error in scrub ioctl [...] > It is important that scrub always returns the stats, even when it > returns an error. This is critical for cancel, as that is how > cancel/resume works, but it should also apply in case of other errors so > that the user can see how much of the scrub was done before the fatal error. That's something we need to document in code and perhaps in the manual pages too.
