On 03/01/2020 10:28, Anand Jain wrote:
On 3/1/20 3:32 AM, Steven Davies wrote:
On 02/01/2020 10:12, Anand Jain wrote:
So this patch introduces a framework where we could add more readmirror
policies, such as routing the IO based on device's wait-queue or manual
when we have a read-preferred device or a policy based on the target
storage caching.
I think the idea is good but that it would be cleaner if the tunable
was named read_policy rather than readmirror as it's more obvious that
it contains a policy tunable.
Um. 'read_policy' sounds good, but I hope it is clear enough to
indicate that we are talking about read for only mirrored-chunks.
Will rename to read_policy.
I think it would be obvious that the policy will only apply to mirrored
chunks; after all, you can only read a chunk from a device that contains it.
Do you envisage allowing more than one policy to be active for a
filesystem? If not, what about using the same structure as the CPU
frequency and block IO schedulers with the format
#cat /sys/block/sda/queue/scheduler
noop [deadline] cfq
Such that btrfs would (eventually) have something like
#cat /sys/fs/btrfs/UUID/read_policy
by_pid [user_defined_device] by_shortest_queue
And in case of user_defined_device, the device for the read shall be
specified in
cat /sys/fs/btrfs/UUID/devinfo/<devid>/read_preferred
0 = unset, 1 = set.
(devinfo patches are in the ML [1] open for comment)
[1]
[PATCH v3 4/4] btrfs: sysfs, add devid/dev_state kobject and attribute
I remember seeing that patch and I think the approach is logical.
Steve
