There are several bug reports of ENOSPC error in
btrfs_run_delalloc_range().
With some extra info from one reporter, it turns out that
can_overcommit() is using a wrong way to calculate allocatable metadata
space.
The most typical case would look like:
devid 1 unallocated: 1G
devid 2 unallocated: 10G
metadata profile: RAID1
In above case, we can at most allocate 1G chunk for metadata, due to
unbalanced disk free space.
But current can_overcommit() uses factor based calculation, which never
consider the disk free space balance.
To address this problem, here comes the per-profile available space
array, which gets updated every time a chunk get allocated/removed or a
device get grown or shrunk.
This provides a quick way for hotter place like can_overcommit() to grab
an estimation on how many bytes it can over-commit.
The per-profile available space calculation tries to keep the behavior
of chunk allocator, thus it can handle uneven disks pretty well.
The RFC tag is here because I'm not yet confident enough about the
implementation.
I'm not sure this is the proper to go, or just a over-engineered mess.
Qu Wenruo (3):
btrfs: Introduce per-profile available space facility
btrfs: Update per-profile available space when device size/used space
get updated
btrfs: space-info: Use per-profile available space in can_overcommit()
fs/btrfs/space-info.c | 15 ++--
fs/btrfs/volumes.c | 205 ++++++++++++++++++++++++++++++++++++++----
fs/btrfs/volumes.h | 10 +++
3 files changed, 203 insertions(+), 27 deletions(-)
--
2.24.1
