On Thu, Dec 05, 2019 at 06:18:15PM +0100, Johannes Thumshirn wrote: > > + > > + return generic_file_buffered_read(iocb, to, ret); > > This could as well call generic_file_read_iter() and would thus make patch 1 > of this series obsolete. I think this is cleaner. I actually much prefer exporting generic_file_buffered_read and will gladly switch other callers not needing the messy direct I/O handling in generic_file_read_iter over to generic_file_buffered_read once this series is merged.
