On Thu, Dec 05, 2019 at 04:32:57PM +0800, Su Yue wrote: > On 2019/12/5 3:29 PM, Qu Wenruo wrote: > > On 2019/12/5 下午12:29, damenly.su@xxxxxxxxx wrote: > >> From: Su Yue <Damenly_Su@xxxxxxx> > >> > >> Simple copy and paste codes, remove useless lock operantions in progs. > >> Th new coming lookup functions are named with suffix _kernel in > >> temporary. > >> > >> Signed-off-by: Su Yue <Damenly_Su@xxxxxxx> > > > > Reviewed-by: Qu Wenruo <wqu@xxxxxxxx> > > > > Just an extra hint, it would be much better if we backport this > > functions to block-group.c. > > > Considered it, then porting functions moved will not require > any suffixes to avoid conflictions. It will be more clean while doing > reform work. But I wonder if it's a proper timing to create > block-group.c in progs. The small incremental changes are IMHO better for now, the kernel and userspace code bases are not close enough so we can just copy code. When the code that implements some logic (and uses same structures) is "close enough", we can copy it directly (eg. the delayed-refs.[ch]), but otherwise it needs to be done in small steps like you do in this patchset.
