Re: [PATCH v2 2/5] btrfs: sysfs, rename device_link add,remove functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/27/19 12:40 AM, David Sterba wrote:
On Thu, Nov 21, 2019 at 05:33:31PM +0800, Anand Jain wrote:
In preparation to add btrfs_device::dev_state attribute in
   /sys/fs/btrfs/UUID/devices/

But we don't want to add any attributes to that directory, is this some
leftover from the previous iterations?

No actually. We discussed to add <devid>/dev_state under UUID/devices
here [1].
[1]
https://lore.kernel.org/linux-btrfs/516598e6-4968-4535-cf6b-12402518b7cc@xxxxxxxxxx/

Looks like you still prefer separate UUID/devinfo directory as you
mentioned here [2]

[2]
https://lore.kernel.org/linux-btrfs/20191118154556.GJ3001@xxxxxxxxxxxxx/

?

Thanks, Anand

Rename btrfs_sysfs_add_device_link() and btrfs_sysfs_rm_device_link() to
btrfs_sysfs_add_devices_attr() and btrfs_sysfs_remove_devices_attr() as
these functions is going to create more attributes rather than just the
link to the disk. No functional changes.

I think the function name matches what it does, it really links the
device.







[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux