On 2019/11/28 下午7:08, David Sterba wrote: > On Wed, Nov 27, 2019 at 12:30:38PM +0800, Qu Wenruo wrote: >> >> >> On 2019/11/27 上午11:48, Marcos Paulo de Souza wrote: >>> From: Marcos Paulo de Souza <mpdesouza@xxxxxxxx> >>> >>> Current btrfs code returns ENOTCONN when the user tries to create a >>> qgroup on a subvolume without quota enabled. In order to present a >>> meaningful message to the user, we now handle ENOTCONN showing >>> the message "quota not enabled". >>> >>> Signed-off-by: Marcos Paulo de Souza <mpdesouza@xxxxxxxx> >> >> Don't forget the original -EINVAL. >> >> So it needs to cover both -EINVAL (for older kernel) and -ENOTCONN (for >> newer kernel). > > I think for now only ENOTCONN should be interpreted as 'quotas not > enabled' as we can be sure it's just that. But EINVAL means 'invalid > parameter' and this can be interpreted in that context as if the qgroup > ids are wrong etc. > Ah, makes sense. So no need for a new version. Reviewed-by: Qu Wenruo <wqu@xxxxxxxx>
Attachment:
signature.asc
Description: OpenPGP digital signature
