On Thu, Nov 21, 2019 at 05:33:29PM +0800, Anand Jain wrote: > v2: > In v2 I have used better naming compared to v1. For example > btrfs_fs_devices::devices_dir_kobj vs btrfs_fs_devices::devices_kobj > and btrfs_sysfs_add_device_info() vs btrfs_sysfs_add_devices_attr, > as I am following a pattern that sysfs directories are inherently > kobjects, which holds files as attributes. We could drop sysfs prefix > also because kobj and attr already indicate that they are part of > sysfs. But people not familiar with sysfs terminology might have to > wonder a little bit, so didn't make that bold changes. I think the _sysfs_ part of the function is a good thing and makes it clear that it belongs to the sysfs interfacing wrappers. > Anand Jain (5): > btrfs: sysfs, rename devices kobject holder to devices_kobj > btrfs: sysfs, rename device_link add,remove functions > btrfs: sysfs, btrfs_sysfs_add_fsid() drop unused argument parent > btrfs: sysfs, rename btrfs_sysfs_add_device() > btrfs: sysfs, merge btrfs_sysfs_add devices_kobj and fsid 1,3,4,5 applied, thanks.
