v1->v2: - Fixed the typo where I wasn't checking against total_bytes. - Added the force check to the read only list addition check at the top. - Fixed the comment stating that sinfo_used + num_bytes should be <= total_bytes, that's not the case at all. - Added the various reviewed-by's. Original message below. ------------------------------- Qu has been looking into ENOSPC during relocation and noticed some weirdness with inc_block_group_ro. The problem is this code hasn't changed to keep up with the rest of the reservation system. It still assumes that the amount of space used will always be less than the total space for the space info, which hasn't been true for years since I introduced overcommitting. This logic is correct for DATA, but not for METADATA or SYSTEM. The first few patches are just cleanups, and can probably be taken as is. The final patch is the real meat of the problem to address Qu's issues. This is an RFC because I'm elbow deep in another problem and haven't tested this beyond compile testing, but I think it'll work. Once I've gotten a chance to test it and Qu has tested it I'll update the list if it's good to go as is, or send a V2 with any changes. Thanks, Josef
