From: Marcos Paulo de Souza <mpdesouza@xxxxxxxx> While reading the qgroup code and doing some tests, I found some two things that I would like to change: * Remove some useless code that was being set only to check if fs_info->quota_root was not NULL * Check why creating a qgroup was returning EINVAL The answer to the second point was: EINVAL is returned when a user tries to create/delete/list/assign a qgroup to a subvolume, but this subvolume does not have quota enabled. Talking with David, he suggested to change it to ENOTCONN, following what is currently being used in balance and scrub. So here are the changes. Please take a look! Marcos Paulo de Souza (2): btrfs: qgroup: Cleanup quota_root checks btrfs: qgroup: Return -ENOTCONN instead of -EINVAL fs/btrfs/qgroup.c | 44 +++++++++++++++----------------------------- 1 file changed, 15 insertions(+), 29 deletions(-) -- 2.23.0
