Re: [PATCH 04/22] btrfs: keep track of cleanliness of the bitmap

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 25, 2019 at 02:59:10PM +0100, David Sterba wrote:
> On Sat, Nov 23, 2019 at 08:17:13AM +0800, kbuild test robot wrote:
> > Hi Dennis,
> > 
> > I love your patch! Yet something to improve:
> > 
> > [auto build test ERROR on kdave/for-next]
> > [cannot apply to v5.4-rc8 next-20191122]
> > [if your patch is applied to the wrong git tree, please drop us a note to help
> > improve the system. BTW, we also suggest to use '--base' option to specify the
> > base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
> > 
> > url:    https://github.com/0day-ci/linux/commits/Dennis-Zhou/btrfs-async-discard-support/20191121-230429
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next
> > config: arm-allmodconfig (attached as .config)
> > compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
> > reproduce:
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # save the attached .config to linux build tree
> >         GCC_VERSION=7.4.0 make.cross ARCH=arm 
> > 
> > If you fix the issue, kindly add following tag
> > Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> > 
> > All errors (new ones prefixed by >>):
> > 
> > >> ERROR: "__aeabi_uldivmod" [fs/btrfs/btrfs.ko] undefined!
> 
> That does not point to a particular line, but there's
> 
> +	/* If we ended in the middle of a bitmap, reset the trimming flag. */
> +	if (end % (BITS_PER_BITMAP * ctl->unit))
> +		reset_trimming_bitmap(ctl, offset_to_bitmap(ctl, end));
> 
> added and its "u64 % (unsigned long * int)" that could be the cause.

Yeah that seems to be it. I wasn't careful enough with my u64s. I'm
going to send out v4 which should fix this issue and the uninitialized
variable use in patch 4.

Thanks,
Dennis



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux