On 11/23/19 1:48 AM, David Sterba wrote:
On Wed, Nov 20, 2019 at 01:56:04PM +0800, Anand Jain wrote:
On 11/19/19 6:58 PM, David Sterba wrote:
On Tue, Nov 19, 2019 at 11:24:37AM +0200, Nikolay Borisov wrote:
On 18.11.19 г. 10:46 ч., Anand Jain wrote:
No functional changes. Move functions to bring btrfs_sysfs_remove_fsid()
and btrfs_sysfs_add_fsid() and its related functions together.
Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx>
This seems like pointless code motion.
Yeah, unless there's some other reason to move the code, just plain
moves are not desired.
The reason was - btrfs_sysfs_add_fsid() and btrfs_sysfs_remove_fsid()
are related. Easy to read and verify to have placed them one below
other.
I see that add and remove functions are grouped, so this would move
someting else away:
btrfs_sysfs_remove_fsid + __btrfs_sysfs_remove_fsid
btrfs_sysfs_add_fsid + btrfs_sysfs_add_mounted
Ok.
and device related functions are also grouped by the action type, so we
can keep it like that.
Ok. Grouped by action type.
Thanks, Anand
