On Mon, Nov 18, 2019 at 02:16:44PM +0200, Nikolay Borisov wrote: > The branch of qgroup_rescan_init which is executed from the mount > path prints wrong errors messages. The textual print out in case > BTRFS_QGROUP_STATUS_FLAG_RESCAN/BTRFS_QGROUP_STATUS_FLAG_ON are not > set are transposed. Fix it by exchanging their place. While that's fixing the swapped messages, I'm considering dropping some of the messages completely. Eg. the warning 'rescan in progress' seems useless because why I as a user should be notified about that? If I run rescan twice and it's still in progress, there's no problem. And with similar usability reasoning, look at the messages and drop them eventually. The specific messages were added by Qu in 9593bf49675ef, to improve the message that printed function name and error code. That was an improvement but now I'm questioning the utility of the messages.
