On Mon, Nov 18, 2019 at 02:30:48PM +0800, Qu Wenruo wrote: > We have several compiling errors, in devel branch. > One looks like a false alert from compiler, the first patch will > workaround it. > > 3 warning from libbtrfsutils are due to python3.8 changes. > Handle it properly by using designated initialization, which also saves > us quite some lines. > > Qu Wenruo (4): > btrfs-progs: check/lowmem: Fix a false alert on uninitialized value > btrfs-progs: libbtrfsutil: Convert to designated initialization for > BtrfsUtilError_type > btrfs-progs: libbtrfsutil: Convert to designated initialization for > QgroupInherit_type > btrfs-progs: libbtrfsutil: Convert to designated initialization for > SubvolumeIterator_type > > check/mode-common.c | 2 +- > libbtrfsutil/python/error.c | 49 ++++++++------------------------- > libbtrfsutil/python/qgroup.c | 43 ++++++----------------------- > libbtrfsutil/python/subvolume.c | 44 ++++++----------------------- > 4 files changed, 30 insertions(+), 108 deletions(-) Thanks for fixing the libbtrfsutil parts. For some reason, the convention for Python C extensions is to not use designated initializers, but after this breakage it's definitely safer to use them. I guess Dave already merged these, but FWIW, Reviewed-by: Omar Sandoval <osandov@xxxxxx>
