On Fri, Nov 15, 2019 at 10:16:55AM -0600, Goldwyn Rodrigues wrote:
> +/*
> + * get_iomap: Get the block map and fill the iomap structure
> + * @pos: file position
> + * @length: I/O length
> + * @iomap: The iomap structure to fill
> + */
> +
> +static int get_iomap(struct inode *inode, loff_t pos, loff_t length,
> + struct iomap *iomap)
The function name probably wants a btrfs_ prefix.
> +{
> + struct extent_map *em;
> + iomap->addr = IOMAP_NULL_ADDR;
Please add an empty line after the variable declaration.
> +static int btrfs_dio_iomap_begin(struct inode *inode, loff_t pos,
> + loff_t length, unsigned flags, struct iomap *iomap,
> + struct iomap *srcmap)
> +{
> + return get_iomap(inode, pos, length, iomap);
> +}
Or do we even need the separate helper for now?