On 14/11/2019 11:56, Anand Jain wrote:
> Yes David is correct why a closed device will still remain in the
> dev_alloc_list even after the close here in this patch.
OK, re-visited the Code again. And I think you're right I've moved this
hunk quite a bit:
if (test_bit(BTRFS_DEV_STATE_WRITEABLE, &device->dev_state) &&
device->devid != BTRFS_DEV_REPLACE_DEVID) {
list_del_init(&device->dev_alloc_list);
fs_devices->rw_devices--;
}
My initial intention was to first have the allocations done so I don't
have to undo anything in case of a failure.
I'm back to the drawing board here.
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@xxxxxxx +49 911 74053 689
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5
90409 Nürnberg
Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
