On Tue, Nov 12, 2019 at 2:28 PM Hubert Tonneau <hubert.tonneau@xxxxxxxxxxxxxx> wrote: > > Hi, > > In order to close the RAID5 write hole, I prepose the add a mount option that would change RAID5 (and RAID6) behaviour : > > . When overwriting a RAID5 stripe, first convert it to RAID1 (convert it to RAID1C3 if it was RAID6) > > . Have a background process that converts RAID1 stripes to RAID5 (RAID1C3 to RAID6) > > Expected advantages are : > . the low level features set basically remains the same > . the filesystem format remains the same > . old kernels and btrs-progs would not be disturbed > > The end result would be a mixed filesystem where active parts are RAID1 and archives one are RAID5. > Interesting idea. It would be a compat_ro feature at worst, plausibly it could be a compat feature, just without the guarantees offered by the feature if using an older kernel. Thing is, I'm not sure it's possible to convert just one stripe. I think the minimum conversion unit is the block group. What is the performance penalty if only full stripe writes were allowed? If there's never RMW for a stripe, it avoids the write hole in the first place. For some workloads the performance may be bad, in which case the option to do COW as raid1 or raid1c3, later converting it to raid56 would be better. In effect it'd be using raid1 for performance and safety, and raid5 for efficiency. I think most people would prefer raid1, 2 or 3 copies, for metadata, by default, in lieu of raid56. -- Chris Murphy
