On 12/11/2019 13:40, Qu Wenruo wrote: [...] > Good patchset, but for error injection we have more formal way to do that. > > ALLOW_ERROR_INJECTION() macro along with BPF to override function return > value. > > There is even a more generic script to do that: > https://github.com/adam900710/btrfs-profiler/blob/master/inject.py > > Such tool allow us to only inject error when certain call sites are met, > so it can be pretty handful. Yes I know, but my current test environment is not yet able to handle this. So I resorted to just throw in some hand crafted error injection here. If we find injecting errors in the alloc_device() code path is worthwhile I'll add an ALLOW_ERROR_INJECTION() there. Thanks, Johannes -- Johannes Thumshirn SUSE Labs Filesystems jthumshirn@xxxxxxx +49 911 74053 689 SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 Nürnberg Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
