Re: [PATCH devel] btrfs-progs: subvolume: Implement delete --subvolid <path>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 29, 2019 at 10:05:25AM +0800, Anand Jain wrote:
> > @@ -223,6 +223,7 @@ static int wait_for_commit(int fd)
> >   
> >   static const char * const cmd_subvol_delete_usage[] = {
> >   	"btrfs subvolume delete [options] <subvolume> [<subvolume>...]",
> > +	"btrfs subvolume delete [options] [--subvolid <subvolid> <path>]",
> 
> 
> It should rather be..
> 
> + "btrfs subvolume delete [options] <[-s|--subvolid <subvolid> <path>] | 
> [<subvolume>...]>"

This is hard to understand on the first read, so the preferred way is to
split into more lines when an option changes the overall behaviour, eg.
what plain receive and receive --dump does:


$ ./btrfs receive --help
usage: btrfs receive [options] <mount>
       btrfs receive --dump [options]



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux