Re: [PATCH v4 2/2] btrfs: extent-tree: Ensure we trim ranges across block group boundary

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 25, 2019 at 08:23:54AM -0400, Josef Bacik wrote:
> > @@ -1341,10 +1351,19 @@ int btrfs_discard_extent(struct btrfs_fs_info *fs_info, u64 bytenr,
> >  						  stripe->physical,
> >  						  stripe->length,
> >  						  &bytes);
> > -			if (!ret)
> > +			if (!ret) {
> >  				discarded_bytes += bytes;
> > -			else if (ret != -EOPNOTSUPP)
> > -				break; /* Logic errors or -ENOMEM, or -EIO but I don't know how that could happen JDM */
> > +			} else if (ret != -EOPNOTSUPP) {
> > +				/*
> > +				 * Logic errors or -ENOMEM, or -EIO but I don't
> > +				 * know how that could happen JDM
> > +				 *
> > +				 * Ans since there are two loops, explicitly
> 
> Hate for there to be a v5 at this point, but it should be "and".

Fixed and the first sentence of the comment needed to be updated anyway.



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux