On 22.10.19 г. 5:02 ч., Marcos Paulo de Souza wrote: > From: Marcos Paulo de Souza <mpdesouza@xxxxxxxx> > > While compiling btrfs-progs using clang I found an issue using > __attribute__(fallthrough), which does not seems to work in clang. > > To solve this issue, the code was changed to use /* fallthrough */, which is the > same notation adopted by linux kernel. > > Once these places were changed, -Wimplicit-fallthrough was set in Makefile, to > avoid further implicit-fallthrough cases being added in the future. > > Marcos Paulo de Souza (2): > btrfs-progs: utils: Replace __attribute__(fallthrough) > btrfs-progs: Makefile: Add -Wimplicit-fallthrough > > Makefile | 1 + > common/utils.c | 12 ++++++------ > 2 files changed, 7 insertions(+), 6 deletions(-) > Overall the patch looks good, it just changes the fallthrough to the least common denominator which seems to be a simple comment. In clang 10 the currently used attribute method is also going to be supported. But we'll get most value if we just enable it now, so Reviewed-by: Nikolay Borisov <nborisov@xxxxxxxx>
