On Fri, Oct 18, 2019 at 01:16:03PM +0200, Johannes Thumshirn wrote: > The manual page of btrfsck clearly states 'btrfs check --repair' is a > dangerous operation. > > Although this warning is in place users do not read the manual page and/or > are used to the behaviour of fsck utilities which repair the filesystem, > and thus potentially cause harm. > > Similar to 'btrfs balance' without any filters, add a warning and a > countdown, so users can bail out before eventual corrupting the filesystem > more than it already is. > > Signed-off-by: Johannes Thumshirn <jthumshirn@xxxxxxx> > > --- > Changes to v1: > - Fix grammar mistakes in warning message > - Skip delay with --force --force was added for a different reason, to allow check on a mounted filesystem. I don't think that combining --repair and --force just to allow repair is a good idea. There's a 'dangerous repair' mode for eg. xfs that allows to do live surgery on a mounted filesytem (followed by immediate reboot). We want to be able to do that eventually. I understand where the motivation comes from, let me have a second thought on that.
