On Tue, Oct 15, 2019 at 06:42:17PM +0300, Nikolay Borisov wrote: > Backup roots are always written in a circular manner. By definition we > can only ever have 1 backup root whose generation equals to that of the > superblock. Hence, the 'if' in the for loop will trigger at most once. > This is sufficient to return the newest backup root. > > Furthermore thew newest_gen parameter is always set to the generation > of the superblock. This value can be obtained from the fs_info. > > This patch removes the unnecessary code dealing with the wraparound > case and makes 'newest_gen' a local variable. "This patch cannot be applied without an SOB line." --n. borisov And the rest does not have it either, I'll add it to avoid pointless resends. Tip of the day: use 'git commit -save' for every commit, it adds SOB, opens editor for changelog and also shows the the diff
