Re: [PATCH 03/19] btrfs: keep track of which extents have been discarded

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 7.10.19 г. 23:17 ч., Dennis Zhou wrote:
> Async discard will use the free space cache as backing knowledge for
> which extents to discard. This patch plumbs knowledge about which
> extents need to be discarded into the free space cache from
> unpin_extent_range().
> 
> An untrimmed extent can merge with everything as this is a new region.
> Absorbing trimmed extents is a tradeoff to for greater coalescing which
> makes life better for find_free_extent(). Additionally, it seems the
> size of a trim isn't as problematic as the trim io itself.
> 
> When reading in the free space cache from disk, if sync is set, mark all
> extents as trimmed. The current code ensures at transaction commit that
> all free space is trimmed when sync is set, so this reflects that.
> 
> Signed-off-by: Dennis Zhou <dennis@xxxxxxxxxx>

I haven't looked closely into this commit but I already implemented
something similar in order to speed up trimming by not discarding an
already discarded region twice. The code was introduced by the following
series:
https://lore.kernel.org/linux-btrfs/20190327122418.24027-1-nborisov@xxxxxxxx/
in particular patches 13 to 15 .

Can you leverage it ? If not then your code should, at some point,
subsume the old one.





[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux