On Thu, Sep 26, 2019 at 01:39:58PM +0300, Nikolay Borisov wrote: > >> - if (backref_in_log(log_root, &search_key, dirid, name, name_len)) > >> + ret = backref_in_log(log_root, &search_key, dirid, name, name_len); > >> + if (ret == 1) > >> return true; > > > > This function also needs to be able to return errors and its caller > > check for errors. > > Yes but this is for a follow up patch. The current patch does not make > the code any more broken than it currently is. I'm going to merge the patches, please send the followup patch soon, so we don't forget about adding the proper error handling. Thanks.
