On Mon, Sep 30, 2019 at 03:33:35PM +0200, David Sterba wrote: > On Mon, Sep 30, 2019 at 06:30:21PM +0530, Aliasgar Surti wrote: > > From: Aliasgar Surti <aliasgar.surti500@xxxxxxxxx> > > > > Removed unused return variable and replaced it with returning > > the value directly > > This change has been sent several times and I give the same answer each > time: > > https://lore.kernel.org/linux-btrfs/20190418154913.GO20156@xxxxxxxxxxxxx/ > > "When switching a fuction to return void, please check the whole > callgraph for functions that do not properly handler errors and do > BUG_ON. You won't see errors passed from them so this gives the > impression no error handling is needed in the caller. > > This has been sent in the past, so I can point you to the 2nd paragraph > in > https://lore.kernel.org/linux-btrfs/20180815124425.GM24025@xxxxxxxxxxxxx/ > > hint: btrfs_pin_extent" Okay, reverted back the changes and submitted v3. Thanks, Aliasgar
