Re: [PATCH v3 2/2] btrfs: tree-checker: Fix wrong check on max devid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/9/19 5:12 PM, WenRuo Qu wrote:


On 2019/9/10 下午5:07, Anand Jain wrote:




diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c
index ccd5706199d7..15d1aa7cef1f 100644
--- a/fs/btrfs/tree-checker.c
+++ b/fs/btrfs/tree-checker.c
@@ -686,9 +686,7 @@ static void dev_item_err(const struct
extent_buffer *eb, int slot,
   static int check_dev_item(struct extent_buffer *leaf,
                 struct btrfs_key *key, int slot)
   {
-    struct btrfs_fs_info *fs_info = leaf->fs_info;
       struct btrfs_dev_item *ditem;
-    u64 max_devid = max(BTRFS_MAX_DEVS(fs_info),
BTRFS_MAX_DEVS_SYS_CHUNK);

As I commented in v2.
I see that BTRFS_MAX_DEVS_SYS_CHUNK is not being used anywhere
else after this being removed. So good to delete the define.
I am bit surprised as well if I am missing?

Please check the first patch.

It adds back the reference to it as an early exit for btrfs_alloc_chunk().

 Oh. Right here in the same thread. Ok. Thanks.

Thanks,
Qu

Thanks, Anand





[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux