On 03/09/2019 18:09, David Sterba wrote: >> +if ! [ -f "/sys/fs/btrfs/features/compress_zstd" ]; then >> + _not_run "kernel does not support zstd compression feature" > > Sorry, I misled you with this check. The test needs to detect zstd > support in 'btrfs restore'. The only thing I see right now is to grep > for zstd in output of 'ldd', because unlike for btrfs-convert, the help > does not list the optional features. Well, yes and no. You can compile a btrfs binary with zstd support and run it on a kernel without. The check would catch this case. But I see it can't cope with a btrfs binary without zstd support compiled in indeed. Let me cook something. Byte, Johannes -- Johannes Thumshirn SUSE Labs Filesystems jthumshirn@xxxxxxx +49 911 74053 689 SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 Nürnberg Germany (HRB 247165, AG München) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
