On Tue, Aug 20, 2019 at 02:46:49PM +0000, Vladimir Panteleev wrote: > Hi David, > > On 20/08/2019 14.32, David Sterba wrote: > > On Sat, Aug 17, 2019 at 11:14:34PM +0000, Vladimir Panteleev wrote: > >> - Don't use grep -q, as it causes a SIGPIPE during the countdown, and > >> the balance thus doesn't start. > >> > > This needs -q, otherwise the text appears in the output of make. Fixed. > > What of the SIGPIPE problem mentioned in the commit message? > > If using -q is preferred despite of that, then probably the note about > it should be removed from the commit message, and the "cancel" > afterwards should probably be removed as well (along with its note in > the commit message too), as the SIGPIPE will prevent the balance from > ever starting. > > Perhaps redirecting the output of grep to /dev/null is a better option. Agreed, I've updated the patch to remove -q and add the redirection. > > Applied, thanks. > > Not a big issue but for some reason my email address was mangled > (@panteleev.md instead of @vladimir.panteleev.md). Looks fine when I > look at https://patchwork.kernel.org/patch/11099359/mbox/. Hm, strange. I'll fix the patches from you so they match your expectations. The mangled domain name does not appear anywhere in the mail headers, I wonder what's going on here.
