On Mon, Aug 26, 2019 at 03:37:28PM +0300, Nikolay Borisov wrote:
> Support for asynchronous snapshot creation was originally added in
> 72fd032e9424 ("Btrfs: add SNAP_CREATE_ASYNC ioctl") to cater for
> ceph's backend needs. However, since Ceph has deprecated support for
> btrfs there is no longer need for that support in btrfs. Additionally,
> this was never supported by btrfs-progs, the official userspace tools.
As there were some questions, changelog could link to the mails that
explain why ceph is not intrested anymore.
> @@ -1837,8 +1837,12 @@ static noinline int btrfs_ioctl_snap_create_v2(struct file *file,
> goto free_args;
> }
>
> - if (vol_args->flags & BTRFS_SUBVOL_CREATE_ASYNC)
> + if (vol_args->flags & BTRFS_SUBVOL_CREATE_ASYNC) {
> + pr_warn("BTRFS: async snapshot creation is deprecated and will"
Why not btrfs_warn? pr_warn lacks identification of the filesystem. I'd
also write shortened identifiers of the ioctl and flags. 'async
snapshot' sounds cryptic and it might be hard to actually find what's
the actual source line implementing it.
Though we all know there are no users left, the deprecation process
assumes there are and should make it possible to notice and update the
affected code.
btrfs_warn("SNAP_CREATE_V2 ioctl with CREATE_ASYNC is deprecated and will be removed in ...")
> + " be removed in kernel 5.7\n");
> + pr_warn("BTRFS: START_SYNC ioctl is deprecated and will be removed in "
> + "kernel 5.7\n");
> + pr_warn("BTRFS: WAIT_SYNC ioctl is deprecated and will be removed in "
> + "kernel 5.7\n");
Yeah, like here the ioctl is sufficiently described.
