Hi Josef, On Fri, 16 Aug 2019 at 15:21, Josef Bacik <josef@xxxxxxxxxxxxxx> wrote: > Fix the can_overcommit code to simply see if our current usage + what we > want is less than our current free space plus whatever slack space we > have in the disk is. This solves the problem we were seeing in > production and keeps us from flushing as aggressively as we approach our > actual metadata size usage. FYI - I'm not sure if it was the intended effect of this patch, but it fixes the problem I was seeing where deleting a device or rebalancing a filesystem with a lot of snapshots and extents would fail with -ENOSPC. With this patch, the operation succeeds - although, the operation seems to require more RAM than merely upping the global reserve size (which also allowed the operation to succeed). Hope this helps. Thanks!
