On Mon, Aug 19, 2019 at 03:54:29PM +0300, Nikolay Borisov wrote: > > > On 16.08.19 г. 17:19 ч., Josef Bacik wrote: > > If we already have tickets on the list we don't want to steal their > > reservations. This is a preparation patch for upcoming changes, > > technically this shouldn't happen today because of the way we add bytes > > to tickets before adding them to the space_info in most cases. > > nit: IMO this changelog should be a bit more explicit since this commit > really makes reservations in FIFO order. Have you also quantified what's > the latency impact as I suspect this will introduce such latencies? Reservations were already in FIFO order because we would add new space to existing tickets. This doesn't change the behavior, just makes it so we get the same behavior without refilling. Thanks, Josef
