On Fri, Aug 16, 2019 at 04:35:42PM +0100, Filipe Manana wrote: > On Fri, Aug 16, 2019 at 4:08 PM Josef Bacik <josef@xxxxxxxxxxxxxx> wrote: > > > > We only use the global reserve fallback for truncates, so use > > For truncates? > I would say only for unlinks, rmdir and removing empty block groups. > Or did some of your previous patches changed that, and I missed it, > and now only truncates use it? > Sorry I misspoke, but same basic idea, we only use it when we're removing shit, not adding shit. > > calc_metadata_size instead of calc_insert_metadata_size. > > I wouldn't hurt to be less vague and mention why we do this change (if > this is still used for unlinks/bg removal, we still need to insertion > orphan item, not just remove items). > Argh I misread the orphan stuff, I thought it was earlier/separate from this usage. You're right, let me see if I can just axe this altogether. Thanks, Josef
